Re: [PATCH 0/6] udf: Change some KERN_<level>s and logging neatening

[NamJae Jeon]

2011/10/10 Joe Perches <joe@xxxxxxxxxxx>:
> I reviewed your patch and think it's too large
> for others to review because it combines multiple
> things into a single patch.
>
> I think that adding struct super_block * to udb_debug
> isn't necessary or particularly useful.
>
> Here are the changes to your original patch that I made:
>
> Separate a single large patch into reviewable chunks.
> Don't convert every message type to udf_<foo>.
Hi Joe.
Thank you, you are given a nice clean up.
>
> Joe Perches (6):
> Âudf: Promote some debugging messages to udf_error
> Âudf: Rename udf_error to udf_err
> Âudf: Rename udf_warn to udf_warn
> Âudf: Convert printks to pr_<level>
> Âudf: Neaten logging output, use vsprintf extension %pV
> Âudf: Neaten udf_debug uses
>
> Âfs/udf/balloc.c  Â|  14 ++--
> Âfs/udf/directory.c | Â Â8 +-
> Âfs/udf/inode.c   |  36 ++++-----
> Âfs/udf/lowlevel.c Â| Â Â2 +-
> Âfs/udf/misc.c   Â|  24 ++++---
> Âfs/udf/namei.c   |  Â5 +-
> Âfs/udf/partition.c | Â 11 +--
> Âfs/udf/super.c   | Â214 +++++++++++++++++++++++-----------------------------
> Âfs/udf/truncate.c Â| Â 21 ++---
> Âfs/udf/udfdecl.h  |  35 ++++++---
> Âfs/udf/udftime.c  |  Â3 +-
> Âfs/udf/unicode.c  |  Â6 +-
> Â12 files changed, 178 insertions(+), 201 deletions(-)
>
> --
> 1.7.6.405.gc1be0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/