Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structuresfor omap4

From: Munegowda, Keshava
Date: Mon Oct 10 2011 - 04:52:26 EST


On Fri, Oct 7, 2011 at 4:03 PM, Munegowda, Keshava
<keshava_mgowda@xxxxxx> wrote:
> On Fri, Oct 7, 2011 at 3:05 PM, Paul Walmsley <paul@xxxxxxxxx> wrote:
>> On Fri, 7 Oct 2011, Munegowda, Keshava wrote:
>>
>>> Thanks Paul;
>>> yes, I can your changes in the patches.
>>> so, you don't need v14 from me right? please confirm.
>>> I am preparing/validating next version patches with  OCPIF_SWSUP_IDLE removed.
>>> Thanks for guiding me and helping on the finalizing the hwmod configurations.
>>
>> The first two patches of the series -- the OMAP3/4 hwmod data patches --
>> have been queued for 3.2 in the 'hwmod_devel_3.2' branch of
>> git://git.pwsan.com/linux-2.6
>>
>> So we don't need new versions of those two.
>>
>> But we need to figure out what to do about the remaining three
>> patches.  I still think that the TLL and UHH hwmods should have
>> separate drivers.  Looks like Felipe has a question pending about that
>> but it's unlikely that I'll have time to dig into it for at least a
>> few days.  So I'd encourage you to try splitting those UHH and TLL
>> drivers in the meantime.
>
> some time last week; I had a discussion with Felipe and he is ok to
> have current design as it is
> for now; But, he wants to redesign this driver with UHH and TLL as two
> platform drivers.
> I will have discussion with Felipe and Partha to redesign it soon.


Hi paul and Felipe

Here is the highlights of the change in the design of USB Host which
we can do after kernel 3.2 release;

1. separate the TLL changes from UHH
2. The TLL is be a new platform driver in ./drivers/mfd
3. the TLL platform driver will export apis for enable/disable clocks
and settings.
3. the UHH drivers uses these APIS of TLL based on the port
configurations from board files
you don't need the TLL clocks to
be on while all the ports are in phy mode.

please let me know your thoughts about it.


regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/