Re: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().

[NamJae Jeon]

2011/10/7 Jan Kara <jack@xxxxxxx>:
> On Wed 05-10-11 15:19:58, Joe Perches wrote:
>> On Thu, 2011-10-06 at 00:08 +0200, Jan Kara wrote:
>> > Hello,
>> >
>> > On Mon 03-10-11 22:53:57, Namjae Jeon wrote:
>> > > While reading metadata, if a problem occurs, Print out only one of the
>> > > five case.(It also does not show a checksum properly.) Because currently
>> > > it have been disable by undef udf_debug. ÂIf there is a problem with
>> > > scratched disc or loader, the user needs to know which error happened.
>> > > And I use pr_fmt instead of printk by joe's suggestion. I try to modify
>> > > totally it to pr_fmt also.
>>
>> > Â Thanks for the patch. I'm willing to take the patch since it's an
>> > improvement but what would be even nicer is to have error reporting like in
>> > ext3 / ext4. We would have functions udf_info, udf_warn, udf_err which
>> > also print sb->s_id with each error so that user can better identify on
>> > which filesystem error happened.
>>
>> Modifying the follow-on patch I sent would be pretty trivial.
> ÂSure, I can do that but if Namjae is willing to do it, I'd have less work
> :).
Hi. Jan.

Currently I can not send a patch using git send-email.
maybe it is the problem related with git or patch size...
So I attach a patch. Is it okay? or I resend a patch again..
plz review attach patch.
Thanks.
>
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂHonza
> --
> Jan Kara <jack@xxxxxxx>
> SUSE Labs, CR
>

Attachment: 0001-udf-enable-error-print-in-udf_read_tagged.patch
Description: Binary data