Re: [PATCH] Input: evdev - use monotonic clock for event timestamps

From: Henrik Rydberg
Date: Fri Oct 07 2011 - 07:00:31 EST


> > if the values don't change. The timestamp axis
> > would always change, hence it would always be sent, even if no other
> > axes change. Of course, we can mitigate this with special-case
> > handling of the ABS_TIMESTAMP in the evdev layer.
> >
>
> I'd prefer if we go this route then:
>
> 1. Have input core emit this event. Then we could decide if we should
> suppress it when suppressing entire packet.

If we go this route, we could also make use of the time stamps of the
hardware, when existent.

> 2. Make it MSC_ event.
> 3. Turn it on and off via ioctl since not all users are interested in
> this facility.

Perhaps it is time for the per-file-descriptor event filters.

> OTOH if we do ioctl why don't we simply allow usres select monotnic vs
> wall time in event structure.
>
> Still, why does your clock fluctuate so much that it matters?

Yes, some actual experimental timing data would be most interesting.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/