Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after completetransmitting

From: Tomoya MORINAGA
Date: Tue Oct 04 2011 - 05:15:31 EST


Hi Grant,

1 month has passed. You look very busy, right ?
We've been long waiting for your accept.
Could you review these patch series ?

Thanks in advance.

(2011/09/06 16:58), Tomoya MORINAGA wrote:
> Currently, in case of reading date from SPI flash,
> command is sent twice.
> The cause is that tx-memory clear processing is missing .
> This patch adds the tx-momory clear processing.
>
> Signed-off-by: Tomoya MORINAGA<tomoya-linux@xxxxxxxxxxxxxxx>
> ---
> drivers/spi/spi-topcliff-pch.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index 540c290..1b98b7e 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data *data)
>
> dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent,
> DMA_FROM_DEVICE);
> +
> + dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent,
> + DMA_FROM_DEVICE);
> + memset(data->dma.tx_buf_virt, 0, PAGE_SIZE);
> +
> async_tx_ack(dma->desc_rx);
> async_tx_ack(dma->desc_tx);
> kfree(dma->sg_tx_p);


--
tomoya
ROHM Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/