Re: [PATCH] kmod: prevent kmod_loop_msg overflow in __request_module()

From: Rusty Russell
Date: Mon Oct 03 2011 - 21:18:46 EST


On Fri, 30 Sep 2011 00:18:17 +0200 (CEST), Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Thu, 29 Sep 2011, Andrew Morton wrote:
> > Well, it will take two billion passes through here to cause the
> > overflow. I really hope you found this problem by inspection!
>
> Unfortunately not, it was more painful experience than code reading :)

Cool!

Changing it to unsigned would have helped too. But I've applied
this....

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/