Re: [PATCH 16/26] ARM: pxa: CPU_PJ4 requires IWMMXT

[Eric Miao]

> 8<-----
> Subject: [PATCH] ARM: pxa: CPU_PJ4 requires IWMMXT
>
> The PJ4 based pxa95x cpus all have iwmmxt and there is no way to
> build that code conditionally, so better not ask the user
> in that configuration, in order to prevent broken builds.

I think this is true for other xscale CPUs as well, so either we make
them unconditionally all at once, or we still leave an option here.

It actually looks quite odd to me that CPU_PJ4 is made special here,
what're the real broken builds errors?

>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5ebc5d9..8d66c32 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1071,9 +1071,10 @@ config ARM_TIMER_SP804
> Âsource arch/arm/mm/Kconfig
>
> Âconfig IWMMXT
> - Â Â Â bool "Enable iWMMXt support"
> + Â Â Â bool "Enable iWMMXt support" if !CPU_PJ4
> Â Â Â Âdepends on CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_PJ4
> Â Â Â Âdefault y if PXA27x || PXA3xx || PXA95x || ARCH_MMP
> + Â Â Â default y if CPU_PJ4
> Â Â Â Âhelp
> Â Â Â Â ÂEnable support for iWMMXt context switching at run time if
> Â Â Â Â Ârunning on a CPU that supports it.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/