Re: [PATCH] staging: zcache: reduce tmem bucket lock contention

From: Greg KH
Date: Mon Oct 03 2011 - 19:12:53 EST


On Thu, Sep 29, 2011 at 09:32:26AM -0500, Seth Jennings wrote:
> tmem uses hash buckets each with their own rbtree and lock to
> quickly lookup tmem objects. tmem has TMEM_HASH_BUCKETS (256)
> buckets per pool. However, because of the way the tmem_oid is
> generated for frontswap pages, only 16 unique tmem_oids are being
> generated, resulting in only 16 of the 256 buckets being used.
> This cause high lock contention for the per bucket locks.
>
> This patch changes SWIZ_BITS to include more bits of the offset.
> The result is that all 256 hash buckets are potentially used resulting in a
> 95% drop in hash bucket lock contention.

This patch is somehow corrupted and can't be applied, care to resend it
with Dan's acked-by so that I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/