Re: taskstats root only breaking iotop

[Guillaume Chazarain]

On Thu, Sep 22, 2011 at 2:32 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> Â Â ÂMake TASKSTATS require root access
> Â Â ÂMake taskstats round statistics down to nearest 1k bytes/events

Hello, iotop author here.

With taskstats being root only, what's the benefit of making the stats
imprecise (not that it matters to iotop)?

How about this plan instead:
- byte level stats only if ptrace_may_access() though iotop can
certainly live with 1k rounded values
- rounded stats or just nothing otherwise
- potentially an extra field in the taskstats structure indicating
when the information is degraded

Thanks

-- 
Guillaume
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/