Re: [PATCH] staging: zcache: fix cleancache crash

From: Francis Moreau
Date: Wed Sep 14 2011 - 17:02:50 EST


On Wed, Sep 14, 2011 at 11:26 AM, Francis Moreau <francis.moro@xxxxxxxxx> wrote:
> On Tue, Sep 13, 2011 at 10:56 PM, Dan Magenheimer
> <dan.magenheimer@xxxxxxxxxx> wrote:
>>> From: Seth Jennings [mailto:sjenning@xxxxxxxxxxxxxxxxxx]
>>> Sent: Tuesday, September 13, 2011 1:19 PM
>>> To: gregkh@xxxxxxx
>>> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; ngupta@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>>> francis.moro@xxxxxxxxx; Dan Magenheimer; Seth Jennings
>>> Subject: [PATCH] staging: zcache: fix cleancache crash
>>>
>>> After commit, c5f5c4db, cleancache crashes on the first
>>> successful get. This was caused by a remaining virt_to_page()
>>> call in zcache_pampd_get_data_and_free() that only gets
>>> run in the cleancache path.
>>>
>>> The patch converts the virt_to_page() to struct page
>>> casting like was done for other instances in c5f5c4db.
>>>
>>> Based on 3.1-rc4
>>>
>>> Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>
>>
>> Yep, this appears to fix it!  Hopefully Francis can confirm.
>
> Ok I can give this a try and let you know.

This patch has fixed the issue I was hitting with qemu.

Thanks
--
Francis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/