Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo

From: Dave Hansen
Date: Wed Sep 14 2011 - 14:42:01 EST


On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
>
> static int __init slab_proc_init(void)
> {
> - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> + proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> + &proc_slabinfo_operations);
> #ifdef CONFIG_DEBUG_SLAB_LEAK
> proc_create("slab_allocators", 0, NULL, &proc_sla

If you respin this, please don't muck with the whitespace. Otherwise,
I'm fine with this. Distros are already starting to do this anyway in
userspace.

Reviewed-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/