Re: [PATCH v2 2/3] mmc: add module param to set fault injection attributes

[Per Forlin]

On 14 September 2011 12:05, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> 2011/9/14 Per Forlin <per.forlin@xxxxxxxxxx>:
>
>> +#ifdef CONFIG_FAIL_MMC_REQUEST
>> +
>> +static DECLARE_FAULT_ATTR(fail_default_attr);
>> +static char *fail_request;
>
> This is not used anymore and ...
>
Yes of course. Will remove it.

>> +static int fail_mmc_request_param_set(const char *val,
>> +                                     const struct kernel_param *kp)
>> +{
>> +       setup_fault_attr(&fail_default_attr, (char *) val);
>> +       return 0;
>> +}
>> +
>> +static const struct kernel_param_ops fail_mmc_request_param_ops = {
>> +       .set = fail_mmc_request_param_set
>> +};
>> +module_param_cb(fail_request, &fail_mmc_request_param_ops,
>> +               &fail_request, 0);
>
> you can change this third parameter to NULL.
>
Absolutely..

Thanks,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/