Re: [PATCH v9 2/3] mmc: core: add random fault injection

[Akinobu Mita]

2011/9/14 Per Forlin <per.forlin@xxxxxxxxxx>:

> It's simple and the patch would be just two lines.
> The reason for changing my mind is that it may be useful to be able to
> pass the fault injection attributes even when mmc_core is a module.
>
>> module_param is more complicated than this. Also the parameter is only
>> usefull when when mmc_core is built into the kernel (it's useless when
>> mmc_core is built as a module).
>>
> If you want to enable fault injection for the mmc_core module at load
> time (during mmc initialisation) the param must be used.
> modprobe mmc_core fail_request=1,1,1,1
> As soon as the module is loaded there is no need for the module param anymore.

OK, I agree with you.  The module parameter is the only way
to enable mmc fault injection if CONFIG_FAULT_INJECTION_DEBUG_FS
is disabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/