Re: [PATCH v4] drivers/block/mtip32xx: Adding new driver mtip32xx

[Christoph Hellwig]

Btw, there is another _huge_ issue with the driver, and that is the
lack of any internal queueing.  Remember the make_request interface is
an extremly thin layer (or rather the lack of it) below the filesystem.

So for example if eh_active is non-zero you return -EBUSY to the
filesystems.  That's an error code it a) doesn't recognize and b)
couldn't handle even if it did.  Similarly mtip_hw_get_scatterlist
simply blocks if no tag is currently available instead of queueing
it up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/