Re: [PATCH 11/24] C6X: interrupt handling

[Thomas Gleixner]

On Mon, 12 Sep 2011, Mark Salter wrote:

> On Fri, 2011-09-09 at 16:33 +0200, Thomas Gleixner wrote:
> > On Wed, 31 Aug 2011, Mark Salter wrote:
> > 
> > > + *
> > > + *  Large parts taken directly from powerpc.
> > 
> > Is it really necessary to copy that stuff instead of generalizing it ?
> > I guess that's mostly about the reverse map & Co.
> 
> I have a patch that takes the code out of powerpc and puts in kernel/irq
> where both powerpc and c6x can use it. That leaves us with two files in
> kernel/irq trying to manage hw <--> virt mappings. So, some merging of
> irqdomain.c and the former powerpc code is needed. I'm not sure how that
> should go. At the moment, irqdomain doesn't support dynamic allocation
> of irq_descs, so its not currently suitable for powerpc or c6x.

Grant was working on that as well. You should talk to him.
 
> 
> > > +/*
> > > + * IRQ controller and virtual interrupts
> > > + */
> > 
> > How different is this from PPC ? Looks fairly familiar to me :)
> 
> I had changed it in a few minor ways, but looking again, I probably
> didn't need to change it at all. In the patch to generalize it, I
> simply did s/NUM_ISA_INTERRUPTS/NR_IRQS_LEGACY/.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/