Re: [PATCH 1/2] Staging: comedi: fix printk issue in cb_pcidda.c

[Greg KH]

On Wed, Aug 31, 2011 at 05:23:32PM +0530, Ravishankar K Mallikarjunayya wrote:
> This is a patch to the cb_pcidda.c file that fixes up a printk warning found by the checkpatch.pl tool

Please wrap your changelog comment at 72 columns, like sane people do.

> 
> Signed-off-by: Ravishankar K Mallikarjunayya <ravishankar.km@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/cb_pcidda.c |   23 ++++++++++++-----------
>  1 files changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c
> index 49102b3..661e945 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidda.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidda.c
> @@ -282,7 +282,7 @@ static int cb_pcidda_attach(struct comedi_device *dev,
>  	struct pci_dev *pcidev = NULL;
>  	int index;
>  
> -	printk("comedi%d: cb_pcidda: ", dev->minor);
> +	pr_info("comedi%d: cb_pcidda: ", dev->minor);

If you have a device pointer, then use dev_info() here.

Same goes for the other changes in this series.  Use the proper dev_*
macros.

And what is up with your patch numbering scheme?  Please send me all of
the patches, not a bunch of [1/1] and the like, in one set, all linked
together properly like git-send-email will do.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/