Re: [PATCH] dmaengine: add CSR SiRFprimaII DMAC driver

[Arnd Bergmann]

On Thursday 08 September 2011 20:48:26 Linus Walleij wrote:
> 2011/9/8 Arnd Bergmann <arnd@xxxxxxxx>:
> > On Thursday 08 September 2011, Barry Song wrote:
> >>
> >> this filter is used by all drivers with DMA since every dma channel is
> >> fixed to be assigned to one device.
> >
> > Ok, I see now. I think it would be best to introduce a generic
> > 'filter by device tree property' function or alternatively an
> > dma_of_request_channel function like this:
> 
> You'd have to discuss that with Vinod, the thing is that x86 Atom
> systems are using dmaengine for device slave transfers too, and
> IIRC these things don't use devicetrees. I may be wrong...

Some of them use device tree, some don't.

I'm not saying that we have to convert all drivers to use this, but
for platforms that always have device tree available, it seems by far
the cleanest solution.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/