Re: [RFC] w1: Disable irqs in critical section

[Evgeniy Polyakov]

On Wed, Sep 07, 2011 at 10:48:32AM +0200, Jan Weitzel (j.weitzel@xxxxxxxxx) wrote:
> Interrupting w1_delay in w1_read_bit results in missing the low level
> on the w1 line and receiving "1" instead of "0".
> Adding local_irq_save / local_irq_restore around the critical section

This means that CPU will be essentially stuck for 15 useconds for every
bit transferred, doesn't really look like a good idea.

Are you absolutely sure that missing bit is because of timings and not
some other bug?

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/