RE: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch()

[H Hartley Sweeten]

On Tuesday, September 06, 2011 12:29 PM, Arnd Bergmann wrote:
> On Tuesday 06 September 2011 13:26:12 H Hartley Sweeten wrote:
>> Your patch below does appear to fix the problem.
>> 
>> Tested-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>> 
>> 
>> There is still a bit of #if ugliness with the pm_{prepare,restore}_console.
>> 
>> The source file kernel/power/console.c is compiled when CONFIG_PM_SLEEP is
>> enabled.  But that file ends up empty if CONFIG_VT and CONFIG_VT_CONSOLE are
>> not defined.
>> 
>> I wonder if it would be cleaner to make a new entry in kernel/power/Kconfig:
>> 
>> config PM_SLEEP_CONSOLE
>>         def_bool y
>>         depends on PM_SLEEP && VT && VT_CONSOLE
>> 
>> Then use that config option in the Makefile and in suspend.h.
>
> Yes, that would be cleaner. I would probably move it to drivers/tty/vt
> in the same step and name the option VT_CONSOLE_SLEEP.

Ok.

> Do you want to send a patch?

Will do in just a minute.

> Thanks for testing!

Not a problem!

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/