[PATCH 2/2] Remove unnecessary bdev argument from loop_clr_fd().

From: Ayan George
Date: Tue Sep 06 2011 - 16:04:04 EST


If the loop device is associated (lo->lo_state == Lo_bound), it will
have a valid bdev pointed to by lo->lo_device. There is no reason to
ever pass an additional block_device pointer.

Signed-off-by: Ayan George <ayan.george@xxxxxxxxxxxxx>
---
drivers/block/loop.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 6d0f28d..f6b552e 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -980,10 +980,11 @@ loop_init_xfer(struct loop_device *lo, struct loop_func_table *xfer,
return err;
}

-static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
+static int loop_clr_fd(struct loop_device *lo)
{
struct file *filp = lo->lo_backing_file;
gfp_t gfp = lo->old_gfp_mask;
+ struct block_device *bdev = lo->lo_device;

if (lo->lo_state != Lo_bound)
return -ENXIO;
@@ -1293,7 +1294,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
break;
case LOOP_CLR_FD:
/* loop_clr_fd would have unlocked lo_ctl_mutex on success */
- err = loop_clr_fd(lo, bdev);
+ err = loop_clr_fd(lo);
if (!err)
goto out_unlocked;
break;
@@ -1513,7 +1514,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
* In autoclear mode, stop the loop thread
* and remove configuration after last close.
*/
- err = loop_clr_fd(lo, lo->lo_device);
+ err = loop_clr_fd(lo);
if (!err)
goto out_unlocked;
} else {
--
1.7.4.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/