Re: randconfig broken on choice

From: Arnaud Lacombe
Date: Tue Sep 06 2011 - 11:04:18 EST


Hi,

On Tue, Sep 6, 2011 at 4:52 AM, Matthieu CASTET
<matthieu.castet@xxxxxxxxxx> wrote:
> Hi,
>
> I am using v3.1-rc4 and make randconfig look broken for choice.
> The choice config is always the same or choice entry can have more than one entry.
>
Could you includes testcases showing that behavior, please ?

Btw, try also to include patch inlined, not multipart. That makes
review easier. I know, gmail is not making that easy, but git
send-email works just fine.

Thanks,
- Arnaud

>
> After some debugging, it seems in randomize_choice_values, we don't clean
> SYMBOL_VALID for choice entry.
> And we don't take "sym->def[S_DEF_USER].tri" but the "default sym->cur.tri".
>
> The following patch seems to fix the problem.
>
>
> Matthieu
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/