Re: [PATCH] leds: ledtrig-timer: fix broken sysfs delay handling

[Richard Purdie]

On Mon, 2011-09-05 at 19:55 +0200, Florian Fainelli wrote:
> On Monday 05 September 2011 17:33:03 Johan Hovold wrote:
> > Fix regression introduced by commit
> > 5ada28bf76752e33dce3d807bf0dfbe6d1b943ad (led-class: always implement
> > blinking) which broke sysfs delay handling by not storing the updated
> > value. Consequently it was only possible to set one of the delays
> > through the sysfs interface as the other delay was automatically
> > restored to it's default value. Reading the parameters always gave the
> > defaults.
> > 
> > Cc: stable@xxxxxxxxxx
> > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> 
> Acked-by: Florian Fainelli <florian@xxxxxxxxxxx>

Acked-by: Richard Purdie <rchard.purdie@xxxxxxxxxxxxxxxxxxx>

> > ---
> >  drivers/leds/ledtrig-timer.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/leds/ledtrig-timer.c b/drivers/leds/ledtrig-timer.c
> > index d87c9d0..328c64c 100644
> > --- a/drivers/leds/ledtrig-timer.c
> > +++ b/drivers/leds/ledtrig-timer.c
> > @@ -41,6 +41,7 @@ static ssize_t led_delay_on_store(struct device *dev,
> > 
> >  	if (count == size) {
> >  		led_blink_set(led_cdev, &state, &led_cdev->blink_delay_off);
> > +		led_cdev->blink_delay_on = state;
> >  		ret = count;
> >  	}
> > 
> > @@ -69,6 +70,7 @@ static ssize_t led_delay_off_store(struct device *dev,
> > 
> >  	if (count == size) {
> >  		led_blink_set(led_cdev, &led_cdev->blink_delay_on, &state);
> > +		led_cdev->blink_delay_off = state;
> >  		ret = count;
> >  	}
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/