Re: [PATCH] memcg: drain all stocks for the cgroup before readusage

[KAMEZAWA Hiroyuki]

On Sun,  4 Sep 2011 04:15:33 +0300
"Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> wrote:

> From: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
> 
> Currently, mem_cgroup_usage() for non-root cgroup returns usage
> including stocks.
> 
> Let's drain all socks before read resource counter value. It makes
> memory{,.memcg}.usage_in_bytes and memory.stat consistent.
> 
> Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>

Hmm. This seems costly to me. 

If a user chesk usage_in_bytes in a memcg once per 1sec, 
the kernel will call schedule_work on cpus once per 1sec.
So, IMHO, I don't like this.

But if some other guys want this, I'll ack.

BTW, how this affects memory.stat ?

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/