Re: [PATCH] Staging: hv: vmbus: Show the modalias in/sys/bus/vmbus/devices/*/

[Greg KH]

On Fri, Sep 02, 2011 at 05:53:37PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@xxxxxxx]
> > Sent: Friday, September 02, 2011 12:36 PM
> > To: Olaf Hering
> > Cc: KY Srinivasan; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> > virtualization@xxxxxxxxxxxxxx
> > Subject: Re: [PATCH] Staging: hv: vmbus: Show the modalias in
> > /sys/bus/vmbus/devices/*/
> > 
> > On Fri, Sep 02, 2011 at 06:25:56PM +0200, Olaf Hering wrote:
> > > Show a modalias file in /sys/bus/vmbus/devices/*/
> > > Add a helper function to print the same content in modalias and uevent.
> > >
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > 
> > Nice idea, thanks for this, one minor nit below:
> > 
> > > ---
> > >  drivers/staging/hv/vmbus_drv.c |   21 ++++++++++++++++-----
> > >  1 file changed, 16 insertions(+), 5 deletions(-)
> > >
> > > --- a/drivers/staging/hv/vmbus_drv.c
> > > +++ b/drivers/staging/hv/vmbus_drv.c
> > > @@ -93,6 +93,14 @@ static void get_channel_info(struct hv_d
> > >  		debug_info.outbound.bytes_avail_towrite;
> > >  }
> > >
> > > +#define VMBUS_ALIAS_LEN ((sizeof((struct hv_vmbus_device_id *)0)->guid)
> > * 2)
> > > +static void print_alias_name(struct hv_device *hv_dev, char *alias_name)
> > > +{
> > > +	int i;
> > > +	for (i = 0; i < VMBUS_ALIAS_LEN; i += 2)
> > > +		sprintf(&alias_name[i], "%02x", hv_dev->dev_type.b[i/2]);
> > > +}
> > > +
> > >  /*
> > >   * vmbus_show_device_attr - Show the device attribute in sysfs.
> > >   *
> > > @@ -105,6 +113,7 @@ static ssize_t vmbus_show_device_attr(st
> > >  {
> > >  	struct hv_device *hv_dev = device_to_hv_device(dev);
> > >  	struct hv_device_info device_info;
> > > +	char alias_name[VMBUS_ALIAS_LEN + 1];
> > 
> > Is that too big to put on the stack?  64 bytes, right?  Hm, maybe not.
> > 
> > Wait, hv_device_info is huge, that should be dynamic in the first place.
> > Olaf, not your issue, but KY, want to fix that up?
> 
> hv_device_info is about 101 bytes. I will fix this. Greg, if you are applying Olaf's patch,
> I will generate my patch on top of Olaf's. Let me know.

I'll take his, and then feel free to send me one on top of that fixing
this.

But again, as kernel.org is still down, I can't apply anything until
next week at the earliest, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/