Re: [PATCH 1/2] Staging: comedi: fix line over 80 character issue in s626.c

[Valdis . Kletnieks]

On Fri, 02 Sep 2011 12:58:07 +0530, Ravishankar K Mallikarjunayya said:
> This is a patch to the s626.c file that fixes up a line over 80 character

Patch looks mostly good - but a question:

> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c

> @@ -266,7 +267,11 @@ module_exit(driver_s626_cleanup_module);
>  static int s626_ai_insn_config(struct comedi_device *dev,
>  			       struct comedi_subdevice *s,
>  			       struct comedi_insn *insn, unsigned int *data);
> -/* static int s626_ai_rinsn(struct comedi_device *dev,struct comedi_subdevice *s,struct comedi_insn *insn,unsigned int *data); */
> +/*
> + * static int s626_ai_rinsn(struct comedi_device *dev,
> + * struct comedi_subdevice *s, struct comedi_insn *insn,
> + * unsigned int *data);
> + */

At 4 places, you fix commented-out function prototypes.  Maybe they should
just be deleted instead?

Attachment: pgp00000.pgp
Description: PGP signature