Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

[Linus Walleij]

On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote:

>> +static const struct u300_pmx_func u300_pmx_functions[] = {
>> +     {
>> +             .name = "power",
>> +             .groups = { POWERGRP_INDEX },
>> +             /* Mask is N/A */
>> +     },
>
> Hmmm. That's a lot of _INDEX defines that'd need to be set up, at least
> to fully represent a chip like Tegra. Can the pinmux core be modified
> such that the group list is an array of names (char*) rather than the
> actual numeric IDs of the groups? Still, perhaps we could use the enum
> we already have for this, so perhaps it isn't a big deal...

Well I could think about a lot of ways to do this, but it's basically up
to the driver, the U300 is just some simple example of what you can
do, it's just trying to satisfy the API.

Maybe as part of writing the nVidia driver you find a clever
mechanism for doing this, if it's looking generally useful at that
point then let's move it to the core I'd say.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/