Re: [PATCH] thp: tail page refcounting fix #5

From: Andi Kleen
Date: Thu Sep 01 2011 - 19:45:32 EST


On Thu, Sep 01, 2011 at 04:28:08PM -0700, Andrew Morton wrote:
> On Thu, 1 Sep 2011 17:24:17 +0200
> Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote:
>
> > Ideally direct-io should stop calling get_page() on pages
> > returned by get_user_pages().
>
> Yeah. get_user_pages() is sufficient. Ideally we should be able to
> undo the get_user_pages() get_page() from within the IO completion
> interrupt and we're done.
>
> Cc Andi, who is our resident dio tweaker ;)
>

Noted, I'll put it on my list.

Should not be too difficult from a quick look, just the convoluted
nature of direct-io.c requires a lot of double checking.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/