Re: [ PATCH 1/1 ] coredump: use current->group_leader->comm insteadof current->comm

[Alan Cox]

On Thu, 1 Sep 2011 10:01:39 -0700
Earl Chew <echew@xxxxxxxxxxx> wrote:

> Change corepattern %e and %E to use current->group_leader->comm instead of current->comm.

Which might break stuff.

> A core dump can be triggered from any task in a group, and substituting current->comm
> means that the name of the core file for a process can vary in surprising ways.

Which some people may well be using

> Using current->group_leader->comm makes the name of the core file more consistent
> for a process when used with %e or %E.

In your view, but there is a better way to do this - add a new case and
letter for the behaviour you want. That way you don't break anyone elses
defaults and expectation and people can set a corepattern dependant upon
the group leader.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/