Re: [PATCH v2] pinmux: add a driver for the CSR SiRFprimaII pinmux

[Barry Song]

2011/9/1 Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> On Thu, Sep 1, 2011 at 4:22 AM, Barry Song <Baohua.Song@xxxxxxx> wrote:
>
> > Â-v2:
> > Ârebase to Linus W's v5 patch(v5 is still in discussion);
> > Âadd complete pinmux list table;
> > Âadd gpio ranges;
> > Âreplace mask magic number by bitops;
> > Ârename upmx to spmx
>
> No further comments on this, but now I went in and rewrote
> pinmuxing a bit so that pin groups are a separate concept from
> pinmux (which just refers to a group). Please have a look at
> the U300 driver and see if you can accomodate the changes.
>
> Sorry for the flow of respins but I'm really liking the stuff that
> has come out as a result of Stephen's feedback. Having
> separate groups and functions may look a bit crufty on
> simple pinmuxes but I'm pretty convinced it'll be a win
> for the subsystem when moving to more complex drivers.
>

never mind. it is not too difficult for me to rebase the patch. and
i'm happy to see the great job of you and Stephen.

> > +static const struct sirfsoc_pinmux_func sirfsoc_pinmux_funcs[] = {
> > + Â Â Â {
> > + Â Â Â Â Â Â Â .name = "lcd_16bits",
> > + Â Â Â Â Â Â Â .pins = lcd_16bits_pins,
> > + Â Â Â Â Â Â Â .num_pins = ARRAY_SIZE(lcd_16bits_pins),
> > + Â Â Â Â Â Â Â .padmux = &lcd_16bits_padmux,
> > + Â Â Â }, {
> > + Â Â Â Â Â Â Â .name = "lcd_18bits",
> > + Â Â Â Â Â Â Â .pins = lcd_18bits_pins,
> > + Â Â Â Â Â Â Â .num_pins = ARRAY_SIZE(lcd_18bits_pins),
> > + Â Â Â Â Â Â Â .padmux = &lcd_18bits_padmux,
> > + Â Â Â }, {
>
> You can probably simplify this and other things with
> preprocessor macros if you want to, like:
>
> #define SIRF_FUNC_ENTRY(a) \
> { .name = "##a##", .pins = ##a##_pins, .num_pins =
> ARRAY_SIZE(##a##_pins), .padmux = &##a##_padmux }
>
> Then just:
>
> static const struct sirfsoc_pinmux_func sirfsoc_pinmux_funcs[] = {
> Â ÂSIRF_FUNC_ENTRY(lcd_16bits),
>
>
> The macro syntax is probably wrong, the preprocessor always
> craze me out, but you get the idea.

i think it is a good idea.

>
> Thanks,
> Linus Walleij
>
Thanks
barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/