Re: [PATCH] nohz: remove "Switched to NOHz mode" debugging messages

From: Joe Perches
Date: Tue Aug 23 2011 - 15:13:09 EST


On Tue, 2011-08-23 at 13:20 +0200, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> When performing cpu hotplug tests the kernel printk log buffer gets flooded
> with pointless "Switched to NOHz mode..." messages. Especially when afterwards
> analyzing a dump this might have removed more interesting stuff out of the
> buffer.
> Assuming that switching to NOHz mode simply works just remove the printk.

> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
[]
> -
> - printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());

Though I don't know if these are actually particularly
useful messages, perhaps pr_info_ratelimited() might
be appropriate instead.

> @@ -793,10 +791,8 @@ void tick_setup_sched_timer(void)
> - printk(KERN_INFO "Switched to NOHz mode on CPU #%d\n", smp_processor_id());

and here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/