Re: [PATCH] kernel/printk: do not turn off bootconsole inprintk_late_init if keep_bootcon

[Nishanth Aravamudan]

Hi Andrew,

On 19.08.2011 [17:10:24 -0700], Andrew Morton wrote:
> On Tue,  9 Aug 2011 17:02:33 -0700
> Nishanth Aravamudan <nacc@xxxxxxxxxx> wrote:
> 
> > It seems that commit 7bf693951a8e5f7e600a45b74d91d962a453146e doesn't
> > always achieve what it aims, as printk_late_init() runs it
> > unconditionally turns off all boot consoles. With this patch, I am able
> > to see more messages on the boot console in KVM guests than I can
> > without, when keep_bootcon is specified.
> > 
> > Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> > Cc: Greg KH <gregkh@xxxxxxx>
> 
> The patch is applicable to 2.6.39.x and to 3.0.x but I'm unable to work
> out if the end-user impact is sufficiently serious to warrant
> backporting the fix into those kernels.
> 
> Please let us know you opinion on this.

Sorry for the delay in responding. I think it is appropriate for the
relevant -stable trees. However, it's more of an annoyance than a
serious bug (ideally you don't need to keep the boot console around as
console handover should be working -- I was encountering a situation
where the console handover wasn't working and not having the boot
console available meant I couldn't see why).

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@xxxxxxxxxx>
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/