Re: [PATCH 4/7] VFS: Add generic_file_llseek_size

[Andi Kleen]

On Tue, Aug 23, 2011 at 02:51:56PM +0200, Arnd Bergmann wrote:
> On Monday 22 August 2011, Andi Kleen wrote:
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > 
> > Add a generic_file_llseek variant to the VFS that allows passing in
> > the current file size, instead of always using inode->i_size.
> > This can be used to eliminate some cut'n'paste seek code in ext4.
> > 
> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> Ah, very nice. I think you can use the same trick to remove duplication
> in default_llseek by always setting the limit to MAX_LFS_FILESIZE.

Not in this patchkit, but some other time perhaps.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/