Re: [PATCH 04/16] freezer: implement and usekthread_freezable_should_stop()

From: Oleg Nesterov
Date: Tue Aug 23 2011 - 11:46:05 EST


Hi Tejun,

On 08/22, Tejun Heo wrote:
>
> > OK, but then we do
> >
> > current->flags &= ~PF_FREEZING;
> >
> > since PF_FROZEN wasn't cleared this can race with
> >
> > p->flags &= ~PF_FROZEN;
> >
> > No?
>
> Indeed, I removed PF_FREEZING and moved PF_FROZEN to __refrigerator()
> in later patches, so it's already gone.

OK, thanks.

> Patches could have been
> sequenced better, I suppose. But, sequencing fixes for different
> races was already pretty challenging. :)

... and it also makes sense to try to read the whole seried before
asking the question.

although this is not simple. Especially because currently I can't
read it faster than one patch per day ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/