On Sunday, August 21, 2011 5:31 PM, Ryan Mallon wrote:On 22/08/11 10:06, Axel Lin wrote:Probably a lot... Which is one of the reasons linux-next exists.. . ;-)2011/8/22 Ryan Mallon<rmallon@xxxxxxxxx>:Ok, I see now. The change which caused the breakage is fdb697c:On 22/08/11 09:41, Ryan Mallon wrote:hi Ryan,On 22/08/11 00:39, Axel Lin wrote:Actually, having a second look at this it does not look right.ep93xx-fb.c uses interfaces from linux/module.h,What actually changed to make these files broken? Did some other header
so it should include that file. This patch fixes below build errors.
previously include module.h for us? How many other drivers are broken?
Anyway, the change is okay.
Acked-by: Ryan Mallon<rmallon@xxxxxxxxx>
drivers/video/ep93xx-fb.c includes linux/platform.h (as its first include),
which includes linux/driver.h, which includes linux/module.h.
Just tested on Linus' latest tree and both this driver and the ep93xx
backlight driver build fine. What kernel version are you using?
~Ryan
The patch is against linux-next tree.
I got build error for ep93xx-fb.c and ep93xx_bl.c on linux-next tree.
( next-20110819 )
"include: replace linux/module.h with "struct module" wherever
possible". How many other drivers got broken now that device.h does not
include module.h?
Actually, Paul Gortmaker caused this breakage with the commit. He should
take a deeper look and see what it broke. From his commit:
Most of the implicit dependencies on module.h being present by
these headers pulling it in have been now weeded out, so we can
finally make this change with hopefully minimal breakage.