Re: [PATCH] dma-debug: hash_bucket_find needs to allow for offsetswithin an entry (v2)

From: Neil Horman
Date: Mon Aug 22 2011 - 13:23:42 EST


On Mon, Aug 22, 2011 at 06:46:26PM +0200, Roedel, Joerg wrote:
> Hi Neil,
>
> I applied your patch and did some minor changes and fixed one problem I
> have seen. Find the edited version appended, when this is fine for you I
> push it.
>
> Thanks,
> Joerg
>
> On Mon, Aug 08, 2011 at 03:13:54PM -0400, Neil Horman wrote:
> > + range += (1 << HASH_FN_SHIFT);
> > + put_hash_bucket(*bucket, flags);
> > + index.dev_addr -= HASH_FN_SHIFT;
>
> This should be index.dev_addr -= (1 << HASH_FN_SHIFT), right?
>
Yup, thats right, good catch, thanks!
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/