Re: [PATCH 01/16] freezer: fix current->state restoration race inrefrigerator()

From: Tejun Heo
Date: Sat Aug 20 2011 - 04:14:13 EST


Hello, Rafael.

On Fri, Aug 19, 2011 at 11:08:59PM +0200, Rafael J. Wysocki wrote:
> On Friday, August 19, 2011, Tejun Heo wrote:
> > refrigerator() saves current->state before entering frozen state and
> > restores it before returning using __set_current_state(); however,
> > this is racy, for example, please consider the following sequence.
> >
> > set_current_state(TASK_INTERRUPTIBLE);
> > try_to_sleep();
>
> Did you mean try_to_freeze() here?

Heh, yeah, I'm constantly being confused among try_to_freeze(),
try_to_sleep() and try_to_wake_up(). Will update. ;)

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/