Re: [PATCH v2 07/43] blackfin: Use set_current_blocked() and block_sigmask()

From: Mike Frysinger
Date: Sat Aug 20 2011 - 00:01:32 EST


On Fri, Aug 19, 2011 at 12:46, Matt Fleming wrote:
> --- a/arch/blackfin/kernel/signal.c
> +++ b/arch/blackfin/kernel/signal.c
> - Â Â Â if (ret == 0) {
> - Â Â Â Â Â Â Â spin_lock_irq(&current->sighand->siglock);
> - Â Â Â Â Â Â Â sigorsets(&current->blocked, &current->blocked,
> - Â Â Â Â Â Â Â Â Â Â Â Â &ka->sa.sa_mask);
> - Â Â Â Â Â Â Â if (!(ka->sa.sa_flags & SA_NODEFER))
> - Â Â Â Â Â Â Â Â Â Â Â sigaddset(&current->blocked, sig);
> - Â Â Â Â Â Â Â recalc_sigpending();
> - Â Â Â Â Â Â Â spin_unlock_irq(&current->sighand->siglock);
> - Â Â Â }
> + Â Â Â if (ret == 0)
> + Â Â Â Â Â Â Â block_sigmask(ka, sig);

the Blackfin version holds siglock and calls recalc_sigpending() while
block_sigmask() does neither. i'm guessing that is expected behavior
now ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/