Re: [PATCH] x86: jump_label: arch_jump_label_text_poke_early: addmissing __init

From: Steven Rostedt
Date: Fri Aug 19 2011 - 17:13:26 EST


On Fri, 2011-08-19 at 17:51 -0300, Kevin Winchester wrote:
> On 19 August 2011 15:20, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > On Tue, 2011-08-16 at 21:04 -0300, Kevin Winchester wrote:
> >> arch_jump_label_text_poke_early calls text_poke_early, which is
> >> an __init function. Thus arch_jump_label_text_poke_early should
> >> be the same.
> >
> > but text_poke_early is not __init but instead __init_or_module. Your
> > patch just caused this bug:
> >
>
> Sorry about that. I have:
>
> # CONFIG_MODULES is not set
>
> which makes __init_or_module equivalent to __init for me. Thus the
> patch was fine for my case, but I expect your modification is the
> right thing to do overall.

Um yeah.

I guess you're another one just like Peter Zijlstra ...

"Modules? Modules? We don't need no stinking modules!"

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/