Re: [REGRESSION][BISECTED] Notebook crashes upon detecting the PCIsubsystem with kernels >= 2.6.24-rc7

From: RogÃrio Brito
Date: Fri Aug 19 2011 - 14:49:48 EST


Hi once again.

2011/8/19 RogÃrio Brito <rbrito@xxxxxxxxxx>:
> ,----[ git bisect bad ]
> | 12c22d6ef299ccf0955e5756eb57d90d7577ac68 is the first bad commit
> | commit 12c22d6ef299ccf0955e5756eb57d90d7577ac68
> | Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> | Date: Â Wed Mar 26 11:22:40 2008 -0700
> |
> | Â Â Revert "PCI: remove transparent bridge sizing"
(...)
> `----

Reverting the commit above with the patch below makes me able to
compile and run Linus's v3.1-rc2:

diff --cc drivers/pci/setup-bus.c
index 8a1d3c7,125e7b7..0000000
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@@ -783,16 -486,14 +783,14 @@@ void __ref __pci_bus_size_bridges(struc
break;

case PCI_CLASS_BRIDGE_PCI:
+ /* don't size subtractive decoding (transparent)
+ * PCI-to-PCI bridges */
+ if (bus->self->transparent)
+ break;
pci_bridge_check_ranges(bus);
- if (bus->self->is_hotplug_bridge) {
- additional_io_size = pci_hotplug_io_size;
- additional_mem_size = pci_hotplug_mem_size;
- }
- /*
- * Follow thru
- */
+ /* fall through */
default:
- pbus_size_io(bus);
+ pbus_size_io(bus, 0, additional_io_size, add_head);
/* If the bridge supports prefetchable range, size it
separately. If it doesn't, or its prefetchable window
has already been allocated by arch code, try



--
RogÃrio Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/