Re: [PATCH] apm-emulation: use wait_event_freezable() instead offreezer_[do_not_]count()

[Tejun Heo]

Hello,

On Thu, Aug 18, 2011 at 07:35:11PM +0200, Oleg Nesterov wrote:
> > Use wait_event_freezable() instead.
> >
> > The only annoyance is that wait_event_freezable() wakes up with
> > -ERESTART if there are pending signals
> 
> IOW, we do not have wait_event_freezable_uninterruptible/etc.

Yeap, we can add it but let's leave it alone for now.

> Perhaps we can introduce TASK_FREEZABLE ? It should be used along
> with TASK_UNINTERRUPTIBLE (like TASK_WAKEKILL). freeze_task() can
> use TASK_INTERRUPTIBLE | FREEZABLE for wake_up.
> 
> vfork() can use FREEZABLE too (although this is not needed in the
> long term, we should teach it to sleep in TASK_INTERRUPTIBLE).
> 
> But I feel you are going to reimplement freezer completely, in this
> case please ignore.

Hmmm... yeah, I just posted preparation patches for the freezer and
will now try to integrate with the rest of job control stuff.  Not
quite sure how it would turn out yet.  Let's see.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/