Re: [RFC 0/7] Kconfig library check merge

From: Michal Marek
Date: Fri Aug 19 2011 - 10:02:46 EST


On 16.8.2011 07:29, Arnaud Lacombe wrote:
> Hi Michal,
>
> On Tue, Jul 19, 2011 at 9:06 AM, Michal Marek <mmarek@xxxxxxx> wrote:
>> On 18.7.2011 21:03, Arnaud Lacombe wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Jul 1, 2011 at 9:47 PM, Arnaud Lacombe<lacombar@xxxxxxxxx> wrote:
>>>>
>>>> Hi Michal,
>>>>
>>>> You'll find hereafter a splitted-down version of my previous preliminary
>>>> patch. I will eventually need to complete the second commit message, it
>>>> is
>>>> missing the purpose of the change, which AFAIR was a failure of
>>>> something.
>>>>
>>>> Comments welcome!
>>>>
>>>> - Arnaud
>>>>
>>>> Arnaud Lacombe (7):
>>>> kconfig/Makefile: add pretty printer for moc(1)
>>>> kconfig/Makefile: ensure `conf' appears last in `hostprogs-y'
>>>> kconfig/check.sh: prepare for generic check
>>>> kconfig: move QT checks to `scripts/kconfig/check.sh'
>>>> kconfig: move GTK checks to `scripts/kconfig/check.sh'
>>>> kconfig: move ncurses checks to `scripts/kconfig/check.sh'
>>>> kconfig: add stub for nconf checks
>>>>
>>>> scripts/kconfig/Makefile | 155 +++++-----------------
>>>> scripts/kconfig/check.sh | 199
>>>> ++++++++++++++++++++++++++--
>>>> scripts/kconfig/lxdialog/check-lxdialog.sh | 84 ------------
>>>> 3 files changed, 223 insertions(+), 215 deletions(-)
>>>>
>>> ping ?
>>
>> Pong. The series looks fine to me. I have no strong opinion about the name
>> of the check script, pick whatever you like and send a series with your
>> signoff.
>>
> The following changes since commit 322a8b034003c0d46d39af85bf24fee27b902f48:
>
> Linux 3.1-rc1 (2011-08-07 18:23:30 -0700)
>
> are available in the git repository at:
> git@xxxxxxxxxx:lacombar/linux-2.6.git master/kconfig-generic-checks
[...]
> kconfig: move ncurses checks to `scripts/kconfig/check.sh'

Hi,
this broke make nconfig for me, because it does no longer passes
-I/usr/include/ncurses to the compiler and so menu.h is not found. Also,
scripts/kconfig/lxdialog/check-lxdialog.sh was left empty by this commit.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/