Re: [PATCH 6/6] Input: elantech - add v3 hardware support

[Ãric Piel]

Op 19-08-11 14:50, Seth Forshee schreef:
> > Yes, in other words, in the case of v1 or v2, the switch(fingers)
> > does nothing if fingers == 0.
> >
> > Maybe you could do put these 3 lines inside a "if (fingers != 0)":
> > +	input_report_abs(dev, ABS_X, x1);
> > +	input_report_abs(dev, ABS_Y, y1);
> > +	elantech_report_semi_mt_data(dev, fingers, x1, y1, x2, y2);
>
> I don't think elantech_report_semi_mt_data() should be moved inside the
> condition. It's doing the right thing when fingers is 0.
Oh, right, it already tests for this case :-) My mistake.

Ãric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/