Re: pstore: change mutex locking to spin_locks

From: Don Zickus
Date: Thu Aug 18 2011 - 13:25:27 EST


On Thu, Aug 18, 2011 at 09:33:17AM -0700, Luck, Tony wrote:
> > But in this case we have a filesystem that can be read/written to from a
> > normal context and also written to from an NMI context
>
> I fixed (avoided) the problem of writing to the pstore filesystem in NMI
> context in my other pstore patch in linux-next ("defer inserting OOPS entries in pstore").

Ok, just found that patch. That fixes one of the issues. :-)

>
> So the remaining locking requirement in pstore is just to protect
> the non-volatile backing store from simultaneous access.

Right. It is still awkward to have userspace write to the pstore and then
be interrupted by an NMI who wants to write to the pstore without causing
deadlocks. But I think we will get there.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/