Re: [PATCH 1/2] mmc: add functions to enable/disable aggressiveclock gating

[Mika Westerberg]

On Wed, Aug 17, 2011 at 03:19:14PM +0300, Mika Westerberg wrote:
> On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote:
> > 
> > I would suggest that in all patches using these functions, try
> > to replace:
> > 
> > mmc_host_clk_disable() -> mmc_host_clk_ungate()
> > mmc_host_clk_enable() -> mmc_host_clk_gate()
> > 
> 
> Wow, that is indeed *much* cleaner way of doing this!
> 
> One thing is that if I call these from those ios functions,
> mmc_host_clk_ungate() will always try to restore the clock
> even if there is really no need. Do you see this as a problem?
> 
> > Please tell us if this works!
> 
> Certainly. I'll try this overnight and see whether it works.

The device survived overnight reboot loop test, so this scheme seems to
work.

I'll prepare a new series which uses mmc_host_clk_{ungate|gate}().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/