Re: [PATCH] checkpatch: do not test/warn of leading whitespacebefore signature tags

From: Jeff Kirsher
Date: Thu Aug 18 2011 - 05:21:35 EST


On Thu, 2011-08-18 at 01:56 -0700, Joe Perches wrote:
> On Thu, 2011-08-18 at 01:43 -0700, Jeff Kirsher wrote:
> > I understand what your saying, and I think that your suggestion about
> > possibly implementing a "--input=git" option to checkpatch.pl might be a
> > happy middle ground to resolve the numerous false warnings this check
> > produces.
>
> As far as I can tell, --ignore= suffices.
>
> If you really want to use checkpatch for checking
> already committed patches, maybe you should not
> use git log but use git format-patch instead.
>
> $ git format-patch -1 --stdout | ./scripts/checkpatch.pl -
>
> That works without any problems.

Thank you Joe, I will take a look at how we validate patches with
checkpatch.pl and hopefully we can reduce the time I take reviewing
checkpatch.pl warnings.

Attachment: signature.asc
Description: This is a digitally signed message part