Re: [PATCH] checkpatch: do not test/warn of leading whitespacebefore signature tags

From: Jeff Kirsher
Date: Thu Aug 18 2011 - 04:43:47 EST


On Thu, 2011-08-18 at 01:31 -0700, Joe Perches wrote:
> On Thu, 2011-08-18 at 01:26 -0700, Jeff Kirsher wrote:
> > I understand what you saying and asking, my point here is the that the
> > "default" style should be understood by checkpatch.pl and not produce
> > false warnings.
>
> And I still disagree.
>
> checkpatch should consider whatever
> input it gets as if it's a patch.
>
> So, if you really want to feed
> git log output as input to checkpatch
> you should format that output
> appropriately and the best way to do
> that is to use git log --format=etc.
>
> Don't suggest removing useful checks.
>

I understand what your saying, and I think that your suggestion about
possibly implementing a "--input=git" option to checkpatch.pl might be a
happy middle ground to resolve the numerous false warnings this check
produces.

Attachment: signature.asc
Description: This is a digitally signed message part