[PATCH] checkpatch: do not test/warn of leading whitespace before signature tags

[Jeff Kirsher]

From: Bruce Allan <bruce.w.allan@xxxxxxxxx>

Commit 2011247 introduced additional style checks for signature tags in
patches which is good.  Unfortunately, now whenever patches are checked
by piping the output of 'git show' or 'stg show' through checkpatch it
warns not to use whitespace before all signature tags since these (and the
rest of the patch description) are indented.  Remove this test/warning.

Signed-off-by: Bruce Allan <bruce.w.allan@xxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Cc: Anish Kumar <anish198519851985@xxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Tested-by:  Aaron Brown  <aaron.f.brown@xxxxxxxxx>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
---
 scripts/checkpatch.pl |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9d761c9..a2a205a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1539,17 +1539,12 @@ sub process {
 		}
 
 # Check signature styles
-		if ($line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
-			my $space_before = $1;
-			my $sign_off = $2;
-			my $space_after = $3;
-			my $email = $4;
+		if ($line =~ /^\s*($signature_tags)(\s*)(.*)/) {
+			my $sign_off = $1;
+			my $space_after = $2;
+			my $email = $3;
 			my $ucfirst_sign_off = ucfirst(lc($sign_off));
 
-			if (defined $space_before && $space_before ne "") {
-				WARN("BAD_SIGN_OFF",
-				     "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
-			}
 			if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
 				WARN("BAD_SIGN_OFF",
 				     "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/