Re: [PATCH 6/6] Input: elantech - add v3 hardware support

From: Li Zefan
Date: Wed Aug 17 2011 - 23:47:28 EST


>> +
>> + case 3:
>> + if (elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
>> + elantech_ps2_command(psmouse, NULL, ETP_REGISTER_READWRITE) ||
>> + elantech_ps2_command(psmouse, NULL, ETP_PS2_CUSTOM_COMMAND) ||
>> + elantech_ps2_command(psmouse, NULL, reg) ||
>> + elantech_ps2_command(psmouse, param, PSMOUSE_CMD_GETINFO)) {
>> + rc = -1;
>> + }
> Prefer to remove these big brace ?
> also with "case 1, case 2 "?

Just wondering What's wrong with this piece of code and what do you
sugguest to improve it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/