Re: [PATCH] powerpc/eeh: remove eeh_event_handler()->daemonize()

From: Oleg Nesterov
Date: Wed Aug 17 2011 - 13:30:48 EST


On 08/16, Tejun Heo wrote:
>
> On Tue, Aug 16, 2011 at 09:08:58PM +0200, Oleg Nesterov wrote:
> > daemonize() is only needed when a user-space task does kernel_thread().
> >
> > eeh_event_handler() thread is created by the worker kthread, and thus
> > it doesn't need the soon-to-be-deprecated daemonize().
> >
> > Note: looks like eeh_event_wq can be static and it can do all work
> > itself without kernel_thread().
> >
> > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

> How do you wanna route these? Through -mm?

Oh, I don't know. -mm, or probably maintainers can pick them.
They don't depend on each other.



Btw. Perhaps we should kill CLONE_KERNEL? And note that the only
user is eeh_thread_launcher().

The problem is, CLONE_KERNEL looks as "use me if you want to create
a kernel thread". But CLONE_SIGHAND means the kernel thread should
not play with signals, and this is not obvious.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/