Re: [PATCH] usb: gadget: get rid of USB_GADGET_DUALSPEED andUSB_GADGET_SUPERSPEED

[Alan Stern]

On Wed, 17 Aug 2011, Michal Nazarewicz wrote:

> >>>> --- a/drivers/usb/gadget/file_storage.c
> >>>> +++ b/drivers/usb/gadget/file_storage.c
> >>>> @@ -3562,11 +3562,7 @@ static void fsg_resume(struct usb_gadget  
> >>>> *gadget)
> >>>>  static struct usb_gadget_driver		fsg_driver = {
> >>>> -#ifdef CONFIG_USB_GADGET_DUALSPEED
> >>>>  	.speed		= USB_SPEED_HIGH,
> >>>> -#else
> >>>> -	.speed		= USB_SPEED_FULL,
> >>>> -#endif
> >>>>  	.function	= (char *) fsg_string_product,
> >>>>  	.unbind		= fsg_unbind,
> >>>>  	.disconnect	= fsg_disconnect,
> 
> >>> You mustn't remove the .speed field entirely.  Set it to  
> >>> USB_SPEED_HIGH.
> 
> >> Please note that the field is not in fact removed.
> 
> > No, but you removed its initializer and as a result, it will be set to
> > 0 whereas it should be set to USB_SPEED_HIGH.
> 
> The initializer is still there. ;)  Only the â#â lines and the initializer
> in the â#elseâ part are removed.

I must be going selectively blind.  Never mind...

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/